[data grid] Change test dom check from /jsdom/ to /jsdom|HappyDOM/ #15634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables testing with Happy DOM without annoying warnings popping up. Fixes mui#10374.
jedesroches
changed the title
|
Deploy preview: https://deploy-preview-15634--material-ui-x.netlify.app/ |
romgrk
added
component: data grid
romgrk
approved these changes
Nov 28, 2024
|
Cherry-pick PRs will be created targeting branches: v7.x |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
…15634) Co-authored-by: Joachim Desroches <jo@thedesroches.net>
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
changed the title
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
…ui#15634) Co-authored-by: Joachim Desroches <jo@thedesroches.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables testing with Happy DOM without annoying warnings popping up. Fixes #10374.
Changelog
Detect HappyDOM like jsdom through the user agent string to avoid width and height warnings during tests.